Skip to content

Conversation

@c-bata
Copy link
Member

@c-bata c-bata commented Oct 29, 2025

Motivation

See #336 for the motivation.

Description of the changes

Disable scheduled runs for PyTorch and visualization temporarily.

@y0z y0z assigned y0z and sawa3030 Oct 30, 2025
Comment on lines 4 to 7
# TODO(c-bata): Uncomment the following lines after fixing the examples.
# See https://github.com/optuna/optuna-examples/issues/336 for details.
# schedule:
# - cron: '0 15 * * *'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have a strong preference, but may I suggest disabling only the skorch step for now? My understanding is that disabling this part alone should be sufficient.

    - name: Run skorch example
      # TODO(c-bata): Uncomment the following lines after fixing the examples.
      # See https://github.com/optuna/optuna-examples/issues/336 for details.
      # schedule:
      if: ${{ github.event_name != 'schedule' }}
      run: |
        python pytorch/skorch_simple.py
      env:
        OMP_NUM_THREADS: 1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review! I applied your suggestion in 62deb7d.

Copy link
Member

@y0z y0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0z y0z added the CI Continuous integration. label Nov 4, 2025
@y0z y0z added this to the v4.7.0 milestone Nov 4, 2025
@y0z y0z removed their assignment Nov 4, 2025
Copy link
Collaborator

@sawa3030 sawa3030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update. LGTM

@sawa3030 sawa3030 merged commit f192f3c into optuna:main Nov 6, 2025
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous integration.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants